search

VarIr / scikit-hubness

A Python package for hubness analysis and high-dimensional data mining
BSD 3-Clause "New" or "Revised" License
44 stars 10 forks source link

FEAT ANN method ONNG from ngtpy #24

Closed VarIr closed 4 years ago

VarIr commented 5 years ago

An additional wrapper for an approximate nearest neighbor algorithm, ONNG from the ngtpy package. See also #22

codecov-io commented 5 years ago

Codecov Report

Merging #24 into develop will increase coverage by 0.14%. The diff coverage is 99.17%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #24      +/-   ##
===========================================
+ Coverage    98.93%   99.08%   +0.14%     
===========================================
  Files           51       53       +2     
  Lines         4129     4348     +219     
  Branches       432      464      +32     
===========================================
+ Hits          4085     4308     +223     
+ Misses          24       20       -4     
  Partials        20       20
Impacted Files Coverage Δ
skhubness/neighbors/tests/test_rptree.py 100% <ø> (ø) :arrow_up:
skhubness/neighbors/__init__.py 100% <100%> (+14.28%) :arrow_up:
skhubness/neighbors/tests/test_onng.py 100% <100%> (ø)
skhubness/neighbors/onng.py 100% <100%> (ø)
skhubness/neighbors/tests/test_neighbors.py 99.78% <100%> (ø) :arrow_up:
skhubness/neighbors/base.py 95.72% <84.61%> (+0.32%) :arrow_up:
skhubness/neighbors/tests/test_lof.py 97.87% <0%> (-0.02%) :arrow_down:
skhubness/neighbors/regression.py 100% <0%> (ø) :arrow_up:
skhubness/neighbors/graph.py 96.15% <0%> (ø) :arrow_up:
skhubness/neighbors/unsupervised.py 100% <0%> (ø) :arrow_up:
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e24f75d...84de2d6. Read the comment docs.

VarIr commented 5 years ago

Really no idea atm, how to fix MacOS. Let's see, whether NGT devs can solve that, otherwise I'll just exclude ONNG on MacOS.

VarIr commented 4 years ago

There seems to be a bug in the AVX code. Disabling it on macos as a work-around works. Will merge now, and enable AVX on MacOS again, when upstream bug is fixed.