Inherit from baseestimator

VarIr / scikit-hubness

A Python package for hubness analysis and high-dimensional data mining

BSD 3-Clause "New" or "Revised" License

44 stars 10 forks source link

Inherit from baseestimator #28

Closed VarIr closed 3 years ago

VarIr commented 5 years ago

All classes should ideally inherit from sklearn.base.BaseEstimator. This will require the KNeighborsTransformer, which will probably be introduced in scikit-learn v0.22.

The following wrapper need to be made valid BaseEstimators:

[x] HNSW
[x] NNG
[x] ~~FalconnLSH~~
[x] PuffinnLSH
[x] RandomProjectionTree

VarIr commented 4 years ago

So far, only puffinn provides native pickle support. in NNG and RandomProjectionTree we optionally support storing the index on disk/in shared memory to make the wrapper pickleable (and thus valid estimators). This could also be enabled for other methods.

VarIr commented 3 years ago

Pickle support for HNSW/NMSlibTransformer added in v0.3 dev branch, using the same strategy as for the AnnoyTransformer.

VarIr commented 3 years ago

Two years later there is still no way to serialize falconn indexes. Will remove falconn from v0.30.