VarIr / scikit-hubness

A Python package for hubness analysis and high-dimensional data mining
BSD 3-Clause "New" or "Revised" License
44 stars 10 forks source link

FEAT Enable ONNG provided by NGT #50

Closed VarIr closed 4 years ago

VarIr commented 4 years ago

Since NGT 1.8 ONNG optimization is available via the Python API. We can, therefore, now enable ONNG here.

The wrapper is renamed to NNG in order to make clear that first, the standard ANNG is created in any case. Only when the parameter optimize=True is set, the ANNG is optimized to an ONNG.

codecov-io commented 4 years ago

Codecov Report

Merging #50 into master will increase coverage by <.01%. The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   99.04%   99.05%   +<.01%     
==========================================
  Files          54       54              
  Lines        4416     4429      +13     
  Branches      488      489       +1     
==========================================
+ Hits         4374     4387      +13     
  Misses         22       22              
  Partials       20       20
Impacted Files Coverage Δ
skhubness/utils/platform.py 100% <ø> (ø) :arrow_up:
skhubness/neighbors/classification.py 100% <ø> (ø) :arrow_up:
skhubness/neighbors/unsupervised.py 100% <ø> (ø) :arrow_up:
skhubness/neighbors/regression.py 100% <ø> (ø) :arrow_up:
skhubness/neighbors/lof.py 100% <ø> (ø) :arrow_up:
skhubness/neighbors/nng.py 100% <100%> (ø)
skhubness/neighbors/__init__.py 100% <100%> (ø) :arrow_up:
skhubness/neighbors/tests/test_neighbors.py 99.68% <100%> (ø) :arrow_up:
skhubness/neighbors/tests/test_onng.py 100% <100%> (ø) :arrow_up:
skhubness/neighbors/base.py 95.34% <75%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d7ba47...1fc8d3e. Read the comment docs.

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 7af2602b5e6cdf34c82f214a7e276176ab06b4b8 into 8d7ba477160e2d7cdfa3c40e392a34a3e11779b5 - view on LGTM.com

new alerts: