search

Varian-MedicalAffairsAppliedSolutions / MAAS-SFRThelper

Medical Affairs Applied Solutions ESAPI plugin tools to aid in the creation of structure patterns (spheres) or irregular stuctures (straight and angled rods) which can be evaluated or aid in the creation of treatment plans with the intention of not covering traditional PTVs homogeneously.
Other
5 stars 3 forks source link

Added additional Voronoi project to this solution, however github msbuild action breaks now #23

Closed varian-ma closed 1 month ago

varian-ma commented 1 month ago

"D:\a\MAAS-SFRThelper\MAAS-SFRThelper\MAAS-SFRThelper.sln" (default target) (1) -> "D:\a\MAAS-SFRThelper\MAAS-SFRThelper\MAAS-SFRThelper\MAAS-SFRThelper.csproj" (default target) (2) -> "D:\a\MAAS-SFRThelper\MAAS-SFRThelper\Voronoi\Voronoi.csproj" (default target) (3:2) -> (CoreCompile target) -> D:\a\MAAS-SFRThelper\MAAS-SFRThelper\Voronoi\CVT3D.cs(50,24): error CS0103: The name 'HashCode' does not exist in the current context [D:\a\MAAS-SFRThelper\MAAS-SFRThelper\Voronoi\Voronoi.csproj]

See here: https://github.com/Varian-MedicalAffairsAppliedSolutions/MAAS-SFRThelper/actions/runs/10932792792/job/30350191252

varian-ma commented 1 month ago

According to @isachpaz : The voronoi project needs the following nuget package: <package id="Microsoft.Bcl.HashCode" version="1.1.1" targetFramework="net452" /> Somehow the github builder has to be informed to download this package first.

varian-ma commented 1 month ago

I saw @isachpaz added the package id line above to https://github.com/Varian-MedicalAffairsAppliedSolutions/MAAS-SFRThelper/blob/CVT3D/MAAS-SFRThelper/packages.config (I also added it to main, unnecessary). And it is now installed when github does all the other packages during the job/build, as seen in these line:

Installed Microsoft.Bcl.HashCode 1.1.1 from https://api.nuget.org/v3/index.json to C:\Users\runneradmin\.nuget\packages\microsoft.bcl.hashcode\1.1.1 with content hash MalY0Y/uM/LjXtHfX/26l2VtN4LDNZ2OE3aumNOHDLsT4fNYy2hiHXI4CXCqKpNUNm7iJ2brrc4J89UdaL56FA==.
Adding package 'Microsoft.Bcl.HashCode.1.1.1' to folder 'D:\a\MAAS-SFRThelper\MAAS-SFRThelper\packages'
Added package 'Microsoft.Bcl.HashCode.1.1.1' to folder 'D:\a\MAAS-SFRThelper\MAAS-SFRThelper\packages'

However, the build still fails with the same error as OP as seen in the latest built attempt here: https://github.com/Varian-MedicalAffairsAppliedSolutions/MAAS-SFRThelper/actions/runs/10942452969/job/30379496383

isachpaz commented 1 month ago

Hi Anthony,

�

I just replaced the 'Microsoft.Bcl.HashCode’ package with a build-in helping method: HashHelper.CombineHashCodes https://github.com/Varian-MedicalAffairsAppliedSolutions/MAAS-SFRThelper/commit/35bedde61fd1b80c43bce901e29b4ec9adf7e033

�

However, I’m still having problems to run it.

�

Best regards,

�

Ilias

�

�

�

From: Anthony Magliari @.> Sent: Thursday, September 19, 2024 4:09 PM To: Varian-MedicalAffairsAppliedSolutions/MAAS-SFRThelper @.> Cc: isachpaz @.>; Mention @.> Subject: Re: [Varian-MedicalAffairsAppliedSolutions/MAAS-SFRThelper] Added additional Voronoi project to this solution, however github msbuild action breaks now (Issue #23)

�

I saw @isachpaz https://github.com/isachpaz added the package id line above to https://github.com/Varian-MedicalAffairsAppliedSolutions/MAAS-SFRThelper/blob/CVT3D/MAAS-SFRThelper/packages.config (I also added it to main, unnecessary). And it is now installed when github does all the other packages during the job/build, as seen in these line:

Installed Microsoft.Bcl.HashCode 1.1.1 from https://api.nuget.org/v3/index.json to C:\Users\runneradmin.nuget\packages\microsoft.bcl.hashcode\1.1.1 with content hash MalY0Y/uM/LjXtHfX/26l2VtN4LDNZ2OE3aumNOHDLsT4fNYy2hiHXI4CXCqKpNUNm7iJ2brrc4J89UdaL56FA==.

isachpaz commented 1 month ago

Hi Anthony,

�

Now it works fine!

https://github.com/Varian-MedicalAffairsAppliedSolutions/MAAS-SFRThelper/actions/runs/10949618344

�

Best regards,

�

Ilias

�

�

�

From: @. @.> Sent: Thursday, September 19, 2024 10:48 PM To: 'Varian-MedicalAffairsAppliedSolutions/MAAS-SFRThelper' @.***> Subject: RE: [Varian-MedicalAffairsAppliedSolutions/MAAS-SFRThelper] Added additional Voronoi project to this solution, however github msbuild action breaks now (Issue #23)

�

Hi Anthony,

�

I just replaced the 'Microsoft.Bcl.HashCode’ package with a build-in helping method: �HashHelper.CombineHashCodes https://github.com/Varian-MedicalAffairsAppliedSolutions/MAAS-SFRThelper/commit/35bedde61fd1b80c43bce901e29b4ec9adf7e033

�

However, I’m still having problems to run it.

�

Best regards,

�

Ilias

�

�

�

From: Anthony Magliari @. @.> > Sent: Thursday, September 19, 2024 4:09 PM To: Varian-MedicalAffairsAppliedSolutions/MAAS-SFRThelper @. @.> > Cc: isachpaz @. @.> >; Mention @. @.> > Subject: Re: [Varian-MedicalAffairsAppliedSolutions/MAAS-SFRThelper] Added additional Voronoi project to this solution, however github msbuild action breaks now (Issue #23)

�

I saw @isachpaz https://github.com/isachpaz added the package id line above to https://github.com/Varian-MedicalAffairsAppliedSolutions/MAAS-SFRThelper/blob/CVT3D/MAAS-SFRThelper/packages.config (I also added it to main, unnecessary). And it is now installed when github does all the other packages during the job/build, as seen in these line:

Installed Microsoft.Bcl.HashCode 1.1.1 from https://api.nuget.org/v3/index.json to C:\Users\runneradmin.nuget\packages\microsoft.bcl.hashcode\1.1.1 with content hash MalY0Y/uM/LjXtHfX/26l2VtN4LDNZ2OE3aumNOHDLsT4fNYy2hiHXI4CXCqKpNUNm7iJ2brrc4J89UdaL56FA==.

varian-ma commented 1 month ago

Amazing job @isachpaz -- thanks! I verified the cloud build runs on my system.