search

VariantEffect / mavedb-ui

MaveDB UI
GNU Affero General Public License v3.0
1 stars 1 forks source link

Populate Target Properties on Autocomplete Selection #194

Closed bencap closed 1 month ago

bencap commented 1 month ago

Sets additional helper properties on the score set on autocomplete selection of targets to allow the target to be saved directly. This will likely be a short lived change given planned updates to the score set editor.

Closes #192

jstone-uw commented 1 month ago

The taxonomy change looks good to me. I agree this part of the code is messy, but that's not new, and it will likely get refactored soon.

I wondered why we need to set other properties like sequenceType, sequence, label, and accession on the whole component. ScoreSetEditor doesn't seem to have these reactive properties defined (whereas it does have taxonomy and assembly), so I don't think this has an effect. But I might be missing something.

bencap commented 1 month ago

Yeah, you're right. It's a little silly that the reactiveness for target sequences and target accessions works differently; I suppose I just assumed they worked the same. I'll push something up.

bencap commented 1 month ago

Rolled into #195.