Core

[kds1660]

а как мне откатить коммиты, реверт последнего опять затронет index.html, git reset? боюсь напартачить

2016-11-26 15:27 GMT+02:00 Denys notifications@github.com:

@Varkh requested changes on this pull request.

In index.html https://github.com/Varkh/CashMachine-JS-Emulator/pull/20#pullrequestreview-10214603 :

@@ -7,7 +7,6 @@

 <script defer src="https://ajax.googleapis.com/ajax/libs/jquery/3.1.0/jquery.min.js"></script>

-

Remove change from this file. You are creating block.

In js/controller/core.js https://github.com/Varkh/CashMachine-JS-Emulator/pull/20#pullrequestreview-10214603 :

@@ -6,17 +6,71 @@

• @constructor */ function Core(cashModule, cardModule) {
• console.log("Waiting for card");
• this.pin='';

Don't create public variables

In js/controller/core.js https://github.com/Varkh/CashMachine-JS-Emulator/pull/20#pullrequestreview-10214603 :

this.pushCard = function (cardData) {

• console.log("Enter pin");

Pleas don't remove console.log for now. It will help with testing

In js/controller/core.js https://github.com/Varkh/CashMachine-JS-Emulator/pull/20#pullrequestreview-10214603 :

 };

• this.enterPin = function (pin) {
• console.log("Autorized.")
• this.checkCardDate = function () {

This logic will be in CardModule. Remove

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Varkh/CashMachine-JS-Emulator/pull/20#pullrequestreview-10214603, or mute the thread https://github.com/notifications/unsubscribe-auth/AV8voEL26FlqplZx1zBvWMjwnf4SeG7dks5rCDO9gaJpZM4K84R5 .

[kds1660]

вроде реверт сделал все, тогда следующим коммитом сделать переписанное соре и потом можно пуллреквестить