VarnaScelestus / RoR2

Risk of Rain 2 mods.
0 stars 2 forks source link

[Ephemeral Coins] Incompatibility with LunarCoinShareOnPickup #12

Closed ConqAra closed 2 years ago

ConqAra commented 2 years ago

in multiplayer, when someone who's not host picks up a lunar coin with the new moon artifact on, the coins only go to the host while the other player remains with zero. (Idk if it's NECESSARILY an incompatibility with that mod, but when I pick up a coin it doesn't display an added coin either for them so I'm assuming it is)

ALTHOUGH it's appears to only be a visual bug, the player still has my amount of coins that we share function-wise, just still displays to them as "0" no matter how many they pick up.

VarnaScelestus commented 2 years ago

That's interesting. I'm not sure what the other mod touches so I'll have to look into it. Do your individual coin counts work properly with just Ephemeral Coins?

ConqAra commented 2 years ago

Well also quality of rain does this feature too and I had both of them on so I can try disabling lunarcoinshareonpickup and retrying this feature first, then vice versa

ConqAra commented 2 years ago

also to answer your question- they work properly, it's just visually not showing and wont update the coin counter for the other person when it's suppose to share. it'll add the coins for both of us, just won't show up for the non-host

ConqAra commented 2 years ago

without LCSOP (Lunar Coin Share On Pickup mod) and with quality of rain, it doesn't work. without quality of rain and with LCSOP, it doesn't work. with both of them enabled, it still doesn't work.

Either way, regardless of what mod you use that affects / allows lunar coin sharing, having this mod's artifact enabled won't visually show the other player their lunar coins. It will stay at 0, even if THEY are the ones who pick them up and not the host.

VarnaScelestus commented 2 years ago

Changed the behavior of some hooks in 7e24ea9 which should hopefully fix this issue.

PollyEdaline commented 2 years ago

This seems to be fixed for me in the newest update, although as per #15, clients don't seem to have their coin counts visually updated.

VarnaScelestus commented 2 years ago

Thanks for letting me know. I'll continue this in the other report.