feat: Added Navigation Sidebar

Varun-Kolanu / csoc_flutter

Flutter project for introducing flutter to freshers

2 stars 8 forks source link

feat: Added Navigation Sidebar #14

Closed Rasesh2005 closed 2 weeks ago

Rasesh2005 commented 3 weeks ago

Description

Added a sidebar according to requirements of the issue.

Related Issue

Fixes #8

Type of Change

[ ] Bug fix
[x] New feature
[ ] Documentation update

Screenshots (if any):

Added notification bell at top right section instead of side bar.. and fired the overflow by ending the text with...(Do tell me if there's a better solution)

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Varun-Kolanu commented 3 weeks ago

Nice Looking great!

Due to the merging of another PR, your PR has some conflicts. Please resolve accordingly.

And a suggestion, if possible, isolate the side bar as another widget because it might be used in many places in the app

Rasesh2005 commented 3 weeks ago

I did make a seperate widget.. should I place it in a new file ?? and yeah.. will resolve the conflict

Rasesh2005 commented 3 weeks ago

I made a seperate class within home page only. for navigationBar.. should I make a seperate file and put it in there??

Varun-Kolanu commented 3 weeks ago

I made a seperate class within home page only. for navigationBar.. should I make a seperate file and put it in there??

Yeah it would be better if it is put in widgets folder and also resolve the conflicts

Varun-Kolanu commented 2 weeks ago

@Rasesh2005 I'll make the issue a medium one

Also add some dummy page and make the app navigate it to that page when clicked on a tile in sidebar

Rasesh2005 commented 2 weeks ago

will be making a new PR as too many commits have been made after this change..

Varun-Kolanu commented 2 weeks ago

will be making a new PR as too many commits have been made after this change..

Yeah no problems go ahead

Rasesh2005 commented 2 weeks ago

@Varun-Kolanu One Suggestion please, Should I use the same appBar everywhere or should I add a back button on every page so that we can go to every page only from home screen?? (Should not make a difference since I am only making a dummy page but still :) )