Varun-Kolanu / csoc_flutter

Flutter project for introducing flutter to freshers
2 stars 8 forks source link

[FEAT] Add / Edit Subject Page #2

Closed Varun-Kolanu closed 1 week ago

Varun-Kolanu commented 1 month ago

Is your feature request related to a problem? Please describe. The page for creating or editing subjects isn't there yet.

Describe the solution you'd like

Bonus: Add Location of class as current location. If it seems hard, it will be created as a new issue don't worry

Describe alternatives you've considered UI is not fixed. You have liberty to edit the UI

Additional context Rough wireframe of UI:

image

Full Figma: https://www.figma.com/design/SSqE8Fn9qAakayjyhZ9gqf/Attendance-Tracker?node-id=0-1&t=Xpgi43pHobRh2dnD-1

issue-assigner[bot] commented 1 month ago

Comment "@csoc-bot claim" to get this issue assigned or "@csoc-bot abandon" to get this issue unassigned

criticic commented 1 month ago

trying to test something @csoc-bot claim

issue-assigner[bot] commented 1 month ago

@criticic, This issue has been successfully assigned to you! 🚀

criticic commented 1 month ago

Hmm, did it try to assign itself? (because the term is in its own comment)

Varun-Kolanu commented 1 month ago

Hmm, did it try to assign itself? (because the term is in its own comment)

Yeah I have forgot to not include csoc-bot in assigning. Will change :)

criticic commented 1 month ago

is the calendar sort of feature a priority right now? like i think just the days is not enough, because on each specific day class timing maybe different

this issue is just for the attendance feature?

Varun-Kolanu commented 1 month ago

@criticic Yeah we are reminding user to mark his attendance if today is in the timetable of a subject. Timing doesn't matter actually because user can choose when to remind him to mark.

If there are two classes in each day, he can add an extra class.

Yeah this is for attendance feature only. Further issues are being created for different features

criticic commented 1 month ago

I have like a google calendar, which sends a notification 10 mins before class, I think we can include something like this in the future maybe

Varun-Kolanu commented 1 month ago

Hmm nice. We can add that now too if you would like to update the UI according to the needs. Rather than putting days horizontally, we can stack them vertically and timing can be put adjacent to each day. Or else, it can be postponed to later issues

Varun-Kolanu commented 2 weeks ago

@criticic How's the work going on. Any issues?

devrungta commented 1 week ago

@criticic I was assigned the issue to add the subjects page and in order to successfully check out it's functioning, I have aldo added the appropriate methods to add the subjects, now if it is possible, please review the pr mentioned above and add the edit subject button as well since I was unable to do so. Thank you

criticic commented 1 week ago

I will send a PR for this by the weekend, was a bit busy and outside.

devrungta commented 1 week ago

also can you incorporate the edit subject in the home screen to make sure that when marking attendance also, an api call is made to change the fields in the firebase database. Thank you