Varying-Vagrant-Vagrants / VVV

An open source Vagrant configuration for developing with WordPress
https://varyingvagrantvagrants.org
MIT License
4.54k stars 847 forks source link

Retire Custom Dashboard Provisioning #1946

Open tomjn opened 5 years ago

tomjn commented 5 years ago

Right now, there's a special provisioner for the dashboard, with config values to customize it. I believe this is unnecessary, and I'd like to replace it with the following:

This greatly simplifies the whole process of creating a dashboard, reduces the needed documentation greatly, and makes it possible to have multiple dashboards at once.

msaggiorato commented 5 years ago

Would you do a phase out of the dashboard? Still allowing a custom dashboard to be provisioned with the dashboard setting, but displaying a warning to the user that doing this is deprecated?

tomjn commented 5 years ago

No we'd just provison the official dashboard and give it a proper site provisioner script like the site templates. I'd even argue to move it out of a synced folder. People can set up custom dashboards the same way they set up other sites. If the dashboard URL option is set in vvv-custom.yml, redirect the user to that URL

Mte90 commented 4 years ago

So maybe the idea is to convert https://github.com/Varying-Vagrant-Vagrants/VVV/blob/develop/provision/provision-dashboard.sh as vvv-utilities?

GitHub
Varying-Vagrant-Vagrants/VVV
An open source Vagrant configuration for developing with WordPress - Varying-Vagrant-Vagrants/VVV
tomjn commented 4 years ago

Not really, we'd still provision it the same way, we'd just remove all the options to configure it. Possibly run a provision.sh if it's there.

Then, if people want a custom dashboard, there's nothing stopping them creating a dashboard.test site and rolling their own or running a fork