Varying-Vagrant-Vagrants / VVV

An open source Vagrant configuration for developing with WordPress
https://varyingvagrantvagrants.org
MIT License
4.54k stars 848 forks source link

Better Dashboard handling of unexpected domains #2275

Open tomjn opened 4 years ago

tomjn commented 4 years ago

When a domain is loaded that isn't vvv.test but isn't handled yet, the dashboard should:

Mte90 commented 3 years ago

So testing now:

I think that: check if it's a host in the config file that VVV is meant to serve

it is missing that point but I don't know how to test that case.

tomjn commented 3 years ago

I think the best way to implement this is probably via Nginx and static HTML files, the IP/vvv scenario can be handled that way too.

Right now the unhandled/default route is the dashboard, that needs to change

Mte90 commented 3 years ago

So it is something that we need to handle it from VVV and not from the dashboard repo

tomjn commented 3 years ago

Indeed, we currently have code that adds a notice in the dashboard, but I think a base64 VVV logo on a dark background with a message in a box and a link to the docs site in a single php file is best.

Said PHP file would:

Mte90 commented 3 years ago

Seems a plan, so we need to change the labels of the ticket.

Mte90 commented 3 years ago

with the new nginx default html pages this ticket is still valid?

tomjn commented 3 years ago

Yes because if you visit a host that isn't accounted for it still loads the dashboard, the requirements have not been met