Varying-Vagrant-Vagrants / VVV

An open source Vagrant configuration for developing with WordPress
https://varyingvagrantvagrants.org
MIT License
4.54k stars 847 forks source link

Adjust Profiling All Pages On A Site Tideways doc to clarify reprovisioning #2358

Closed tomjn closed 1 year ago

tomjn commented 3 years ago

The Profiling All Pages On A Site section of the docs site at https://varyingvagrantvagrants.org/docs/en-US/references/tideways-xhgui/ indicates that you can use tideways: true to auto-profile a site.

I was speaking with a colleague who was switching back and forth between Xdebug and Tideways, and was under the impression tideways: true would require them to reprovision each time. This is not the case.

We should adjust the docs to avoid this confusion

Mte90 commented 3 years ago

I was looking at this ticket, so the tideyways.json is generated on provision.

https://github.com/Varying-Vagrant-Vagrants/vvv-utilities/blob/master/tideways/provision.sh#L128

Maybe we can create a command that run php "${DIR}/by-site.php" "${VVV_CONFIG}" so it is not required to provision every time but just run this command so it is updated. Or add ?enable-tideways=true in the url.

GitHub
Varying-Vagrant-Vagrants/vvv-utilities
Default utilities provisioned with VVV. Contribute to Varying-Vagrant-Vagrants/vvv-utilities development by creating an account on GitHub.

Maybe modify tideways_on to run that command?

Mte90 commented 3 years ago

Just a ping for this about how to proceed further

Mte90 commented 2 years ago

I can't move on this ticket until this https://github.com/Varying-Vagrant-Vagrants/vvv-utilities/pull/91

tomjn commented 2 years ago

Currently that issue is blocked by yourself, your PR did the opposite of what was requested

Mte90 commented 2 years ago

Uhm seems that PR is for https://github.com/Varying-Vagrant-Vagrants/VVV/issues/2364 I forgot completely the purpose of the pr after an year. PR update as suggested.