Closed ssnepenthe closed 2 years ago
Thanks for opening your first issue here! Be sure to follow the issue template and include your OS/Vagrant/VVV versions! Don't forget you can get support in the VVV slack at https://varyingvagrantvagrants.org/docs/en-US/slack/
VVVJoin the VVV Slack Workspace
I didn't make a PR on the vvv-utilities repo because I'm not sure if it needs to still support ^1.1 for any sort of BC reason.
Feel free to go ahead and make the change, you can do something like ^1.0 || ^2.0
if remember right to keep composer 1 support ( utilities aren't just for the latest VVV version, they run on the old versions that haven't updated yet too )
Also webgrind may not be that useful with xdebug 3 changes and turning off output ( the files were excessive and filling up lots of peoples VMs, and webgrind wouldn't read them anyway, no idea why )
I noticed webgrind was looking for profile files in the wrong directory right after submitting this issue.
Looks like you submitted a pr to fix it back in january. No releases since then though, so for my own use I also changed the webgrind version constraint to dev-master - Probably not ideal for VVV.
Otherwise it seems to be working alright (albeit with only a few minutes of use) with the exception of https://github.com/jokkedk/webgrind/issues/132.
@ssnepenthe Is this still an issue? The composer.json has the 2.0 version at:
https://github.com/Varying-Vagrant-Vagrants/vvv-utilities/blob/master/webgrind/composer.json#L5
I believe i fixed this in:
Can you confirm all is good now?
GitHubOfficial VVV extensions. Contribute to Varying-Vagrant-Vagrants/vvv-utilities development by creating an account on GitHub.
Ping to @ssnepenthe
Sorry about the delay... It seems like this is fixed, thanks!
I think I manually upgraded composer to v2 (2.1.6 currently) but it looks like the develop branch installs composer v2 as well so this should be relevant going forward.
What was The Command Used To Provision
What Kind of VVV Provision Was This
This was a reprovision of an already working VVV
Logs/What Broke
Possible Solution
v2 of the composer installers extender package supports composer v2. Manually bumping the version constraint for oomphinc/composer-installers-extender to ^2.0 worked just fine for me. I didn't make a PR on the vvv-utilities repo because I'm not sure if it needs to still support ^1.1 for any sort of BC reason.
Steps to Reproduce (for bugs)