search

Varying-Vagrant-Vagrants / VVV

An open source Vagrant configuration for developing with WordPress
https://varyingvagrantvagrants.org
MIT License
4.54k stars 847 forks source link

Fix git issue #2595

Closed Mte90 closed 2 years ago

Mte90 commented 2 years ago

Ref: https://github.com/Varying-Vagrant-Vagrants/VVV/issues/2593

So this is a test that is adding the repository in the safe list without fixing the permission itself

Checks

update-docs[bot] commented 2 years ago

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionally any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
GitHub - Varying-Vagrant-Vagrants/varyingvagrantvagrants.org: The VVV docs and website
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.
tomjn commented 2 years ago

we would need this in the site provisioner too, it'll probably impact some utilities provisioners as well, is it not possible to run the command with the necessary user and ownership to avoid needing this?

Mte90 commented 2 years ago

we would need this in the site provisioner too, it'll probably impact some utilities provisioners as well, is it not possible to run the command with the necessary user and ownership to avoid needing this?

I want to see what happen in the CI before to do other changes.

Mte90 commented 2 years ago

So with safe works let's see with noroot.

Mte90 commented 2 years ago

So seems that this PR fix that issue.

tomjn commented 2 years ago

so other provisioners already do this and aren't affected, at least in the main VVV git repo

Mte90 commented 2 years ago

I see that error, working on a fix:

    default: fatal: unsafe repository ('/home/vagrant/.nvm' is owned by someone else)
    default: To add an exception for this directory, call:
    default: 
    default:    git config --global --add safe.directory /home/vagrant/.nvm
    default: fatal: unsafe repository ('/home/vagrant/.nvm' is owned by someone else)
    default: To add an exception for this directory, call:
    default: 
    default:    git config --global --add safe.directory /home/vagrant/.nvm