Varying-Vagrant-Vagrants / VVV

An open source Vagrant configuration for developing with WordPress
https://varyingvagrantvagrants.org
MIT License
4.54k stars 848 forks source link

Bump mariadb 10.5 to mariadb 10.7 #2623

Closed Mte90 closed 1 week ago

Mte90 commented 2 years ago

We need to bump the numbers in the *list files (https://github.com/Varying-Vagrant-Vagrants/VVV/blob/e95f4b70d6eada0486b1d77ed91fa01027e56c6a/provision/core/mariadb/sources-ubuntu-focal.list) and in the provision https://github.com/Varying-Vagrant-Vagrants/VVV/blob/0000e5d0818c55f4cae5427ff9b874fe178cc397/provision/core/mariadb/provision.sh#L11

tomjn commented 2 years ago

What's our plan for upgrading those still on 10.5 and 10.4 without breaking things? If we just bump the source to 10.7 it'll break for anyone trying to upgrade on 10.5/4

Mte90 commented 2 years ago

I didn't saw any issues on upgrading them, I have them also locally on debian and everything worked fine.

tomjn commented 2 years ago

When the sources for 10.4 were changed to 10.5, anybody who had 10.4 would fail provisioning when upgrading because it no longer had access to the 10.4 packages it needed to perform the upgrade.

For this reason, we can't just replace the lines for 10.5 with 10.7 in the sources file.

Mte90 commented 2 years ago

I see in the past we just changed the repositories https://github.com/Varying-Vagrant-Vagrants/VVV/commit/8d3e208b068a6c77e75cdfbff0d43b86efabc4e0

If we change the package to mariadb-server it will always use the latest mariadb version available instead to defining the version and as we are defining the repository for the latest version we want I think that we fix everything.

tomjn commented 2 years ago

that's because this is an active outstanding bug that has not been resolved

tomjn commented 2 years ago

@Mte90 switching to mariadb-server should be a simple swap out though? Even if it doesn't touch this issue it should make upgrades simpler right?

Mte90 commented 2 years ago

on my experience it is a solution that just works with no problems also with other packages.

tomjn commented 1 year ago

now 10.8, as for the problem, we know it happens because people have encountered it and raised issues, no fix was ever implemented for it, so we need a path forwards

Mte90 commented 1 year ago

I didn't got problems on upgrading the mariadb version so I am not sure about the issues we have right now.

tomjn commented 1 week ago

Closing this as the latest develop branch uses 10.11 now