Varying-Vagrant-Vagrants / VVV

An open source Vagrant configuration for developing with WordPress
https://varyingvagrantvagrants.org
MIT License
4.55k stars 849 forks source link

Remove support for hostmanager and hostsupdater Vagrant plugins #2639

Open aldavigdis opened 1 year ago

aldavigdis commented 1 year ago

As hostsupdater is no longer maintained and hostsmanager has dependency issues, removing them as optional alternatives to goodhosts would streamline a lot of things.

Plugin checks in the Vagrantfile are non-functioning as Vagrant.has_plugin? will always return a falsey value as it is currently being used, so that Vagrant will default on using and installing goodhosts no matter if the other plugins as installed.

This also provides opportunities to revamp the Vagrantfile in a comprehensive way. (Subject to separate issue ticket.)

Describe alternatives you've considered

Additional context

It would be useful to have some info on how many users are using the hostsupdater and hostsmanager plugins and if this would potentially cause issues for them and how severe they are.

This was discussed in https://github.com/Varying-Vagrant-Vagrants/VVV/pull/2638.

welcome[bot] commented 1 year ago

Thanks for opening your first issue here! Be sure to follow the issue template and include your OS/Vagrant/VVV versions! Don't forget you can get support in the VVV slack at https://varyingvagrantvagrants.org/docs/en-US/slack/

VVV
VVV Slack Workspace
Join the VVV Slack Workspace
Mte90 commented 1 year ago

Right now we don't know how many people uses them but honestly I think that if have the alert to install the plugin as mandatory it will simple for them to switch to that and avoid so many troubles.