Open fkiraly opened 6 months ago
I'm not against the idea. There are features implemented in this classes which seems very interesting.
But first, I would like to understand how to use the scikit-base
class properly :-)
I think the project discussed in https://github.com/VascoSch92/sequentium/issues/46 will be a good learning experience, i.e., I would like to spend time in implementing this module/package before porting this class here.
makes sense, given that you are interested in helping with that!
Really nice package!
I was wondering, might I interest you in
scikit-base
? https://github.com/sktime/skbaseThere are some features that you might like:
Cumulative(Fibonacci())
or similar - withsklearn
-likeget_params
,set_params
, or added sequences like you want in https://github.com/VascoSch92/sequentium/issues/21__eq__
and__repr__
have default implementations compatible withsklearn