search

VasileiosBouzas / MeshPolygonization

70 stars 17 forks source link

CGAL::Assertion_exception #11

Closed eiiijiiiy closed 2 years ago

eiiijiiiy commented 2 years ago

Dear authors,

Sorry to bother you again!

We ran the Mesh Polygonization on our data.

But CGAL (ver: 5.4.1) threw an error. The log is pasted below.

Parameters (You may need to modify some of them) ------- Distance threshold: 0.8 Importance threshold: 0 Solver: Gurobi terminate called after throwing an instance of 'CGAL::Assertion_exception' what(): CGAL ERROR: assertion violation! Expr: idx < data.size() File: /usr/local/include/CGAL/Surface_mesh/Properties.h Line: 193 Aborted (core dumped)

It seems that our data doesn't fit some requirements of the planarity calculation. May you kindly suggest some tips to prepare the test data?

Many thanks!!

LiangliangNan commented 2 years ago

I quickly looked into your data and found that it has non-manifoldness (to be specific: isolated vertices). I updated the code so now it can handle such defect inputs. Besides, you may also need to tune the parameters to generate a reasonably good result. I tried and you can start by setting the dist_threshold = 1.5. I highly suggest reading our paper to get an idea what the parameters mean.

LiangliangNan commented 2 years ago

I believe this issue has been resolved so I am going to close it. If this is not the case, feel free to reopen it.

eiiijiiiy commented 2 years ago

Sorry for my late reply. Yeah, perfectly solved it. Thanks very much!!