VasiliBaranov / packing-generation

Hard-sphere packing generation in C++ with the Lubachevsky–Stillinger, Jodrey–Tory, and force-biased algorithms and packing post-processing.
MIT License
106 stars 43 forks source link

Error: Inner diameter ratio #22

Open hrushi1994 opened 3 years ago

hrushi1994 commented 3 years ago

Hello Vasili,

this is the first time ever, that I came across an error using your algorithm for Packing Generation. I did not understand exactly where it's gone wrong. Here are the details:

N is 4999 dimensions are 1015.000000 1015.000000 1015.000000 generation mode: start seed 304 steps to write intermediate state 1000 boundaries mode is 1

Reading particle diameters from a file 'diameters'... done. Contraction rate is 0.000132891 Total volume of particles is 7.61523e+08 Theoretical porosity is 0.271742 Global minimum is 0.0279796 Time: 812.871, reduced pressure: 1.00202, actual temperature: 0.200868 WARNING: innerDiameterRatio incorrect. Time: 0. Actual: 0.136002828052313, expected: 0.117803595935057. Closest pair: 86, 2124 Step 0. Inner diameter ratio is 0.136002828052313. Outer diameter ratio is 1.000000000000000. Writing int. packing state...Contraction rate: 1.328910e-04 done. Time: 770.182, reduced pressure: 1.01803, actual temperature: 0.203892 WARNING: innerDiameterRatio incorrect. Time: 0. Actual: 0.238353112300018, expected: 0.060943661885696. Closest pair: 2411, 4092 Time: 724.42, reduced pressure: 1.06063, actual temperature: 0.208434 WARNING: innerDiameterRatio incorrect. Time: 0. Actual: 0.334621974060994, expected: 0.080379124733056. Closest pair: 806, 2998 Time: 662.518, reduced pressure: 1.14343, actual temperature: 0.214324 WARNING: innerDiameterRatio incorrect. Time: 0. Actual: 0.422664666806748, expected: 0.091103110914174. Closest pair: 2339, 3461 Time: 40.7933, reduced pressure: 1.18647, actual temperature: 0.201172 WARNING: innerDiameterRatio incorrect. Time: 0. Actual: 0.428085725034101, expected: 0.051675963068600. Closest pair: 3035, 3653 Time: 0, reduced pressure: inf, actual temperature: 0.200003 WARNING: innerDiameterRatio incorrect. Time: 0. Actual: 0.428085725034101, expected: 0.051675963068600. Closest pair: 3035, 3653 Checking... Calc. porosity is 0.942868 Theoretical porosity is 0.271742 Checking min particle distance in a naive way... ERROR: innerDiameterRatio 0.428086 is not equal to min normalized distance from naive computation 0.051676 in the pair 3035 3653. Probably bugs in distance provider. InnerDiameterRatio is not equal to min normalized distance from naive computation.

What do you interpret from it?

VasiliBaranov commented 3 years ago

Hi,

Please refer to point 1 here: https://github.com/VasiliBaranov/packing-generation#22-program-usage-and-options-for-generation

I.e. you need to run the program at first with the option -fba. Or you can run it only with the option -fba.

Please also refer to this section to select compression rate: https://github.com/VasiliBaranov/packing-generation#14-note-on-final-diameters

And to this section to be able to interpret the results: https://github.com/VasiliBaranov/packing-generation#21-note-on-final-diameters

Hope this helps.

Best Regards, Vasili