search

VasiliBaranov / packing-generation

Hard-sphere packing generation in C++ with the Lubachevsky–Stillinger, Jodrey–Tory, and force-biased algorithms and packing post-processing.
MIT License
106 stars 43 forks source link

add colab notebook and corresponding readme changes #37

Closed sgbaird closed 1 year ago

sgbaird commented 1 year ago

@VasiliBaranov feel free to change as you like

https://github.com/VasiliBaranov/packing-generation/issues/10

VasiliBaranov commented 1 year ago

Dear @sgbaird ,

Thank you very much for the PR! I've approved it! I have a question. I've approved the PR, but when i click on the colab badge, colab shows me this picture:

image

I can click authorize by github, and then see this screen:

image

Then, when i click on the packing_generation.ibynb link, i see the notebook and it seems to work:

image

The notebook URL is this: https://colab.research.google.com/github/VasiliBaranov/packing-generation/blob/master/packing_generation.ipynb

But do you think there is something else we are missing in the links? Maybe we need to set some additional permissions? Or this is the expected process? Thanks!

Best Regards, Vasili

VasiliBaranov commented 1 year ago

Dear @sgbaird ,

nevermind, i've found the problem and fixed it. There was a slight problem in the link, we used packing-generation.ipynb in the file name, while it should have been packing_generation.ipynb (note the hyphen instead of the underscore). I've changed it now in the badge and in the sample usage section and it seems to work. Thank you again! (i have never used colab notebooks before, so it's pretty cool that we have one linked!)

Best Regards, Vasili

sgbaird commented 1 year ago

Sorry about the hyphen vs. underscore issue! Just barely saw this, but glad you got it figured out. You're welcome! Thanks for your help with my various questions :)