VasilioRuzanni / angular-modelizer

Simple and lightweight yet feature-rich models to use with AngularJS apps.
MIT License
26 stars 4 forks source link

Lodash #1

Closed amcdnl closed 10 years ago

amcdnl commented 10 years ago

Why do you require lodash? I like your model layer but I'd never add lodash to my app just for this and I'd say many would agree.

VasilioRuzanni commented 10 years ago

@amcdnl Sorry for the late reply.

Well, thats indeed a concern for me either and I'm looking over how can I break that dependency because I'm on the same page on that with you. Looking for a way to keep the internals as simple as with lodash but without actually requiring it.

After all, since modelizer uses just regular arrays for collections, its easy to include the lodash if convenient but I definitely want it to be completely optional. That being said, there is a lot of thinking over that part, so check for updates, its on the enhancement check-list for some nearest future.

amcdnl commented 10 years ago

@VasilioRuzanni What specific things are you using lodash for? Arrays? Why not ES5/6 shim them...that would future proof your code and remove the dependencies. I use the following in my app: https://gist.github.com/amcdnl/c8b06cb9eeae262efe92

VasilioRuzanni commented 10 years ago

@amcdnl Yes, for arrays too but array stuff is more straightforward to get rid of. I use lodash for things like deep cloning, convenient type checks and some other stuff. But will review getting rid of that, so keep checking.

VasilioRuzanni commented 10 years ago

@amcdnl There we go, lodash dependency is removed with 0.2.0

amcdnl commented 10 years ago

@VasilioRuzanni you rock!

I was actually in the process of drafting my own model layer ( i know right? ) but I couldn't find something that i was in love with. If your open to it, I'd love to merge ideas...

Draft is here: https://gist.github.com/amcdnl/9f5609713ae8a4fd475e ... even if its not a fit i'd love to hear feedback.

VasilioRuzanni commented 10 years ago

@amcdnl I will surely take a look! Thanks!