VasilioRuzanni / angular-modelizer

Simple and lightweight yet feature-rich models to use with AngularJS apps.
MIT License
26 stars 4 forks source link

$loading is always false #2

Closed tsak closed 9 years ago

tsak commented 9 years ago

I've been trying out angular-modelizer and I think it's a great library.

One thing that does not seem to work at the moment is $future.$loading.

I've created a demo here http://embed.plnkr.co/Sdaz3f2N3RvowALDKWIN

$loading basically stays false.

Unless I misunderstood the way it is supposed to work of course.

VasilioRuzanni commented 9 years ago

@tsak yeah, it's on "to fix" list already. Will be fixed shortly. For now it only works for already materialized objects and collections but should surely work with "modelizer methods" like .all() or .query()

Thanks for pointing out anyway!

VasilioRuzanni commented 9 years ago

@tsak Fixed with 6952e74. Feel free to check out and re-open if some related issue persists.

tsak commented 9 years ago

Great stuff. I've update the Plunkr (http://embed.plnkr.co/Sdaz3f2N3RvowALDKWIN) to the new version and it works as expected. Thank you so much for fixing it.