search

VasilioRuzanni / angular-modelizer

Simple and lightweight yet feature-rich models to use with AngularJS apps.
MIT License
26 stars 4 forks source link

Bug - query, fetch and get not returning promise if rejected #5

Closed dani3l closed 9 years ago

dani3l commented 9 years ago

Hi dude

take a look at lines: 1790, 2175, 2609, 2643 https://github.com/VasilioRuzanni/angular-modelizer/blob/master/dist/angular-modelizer.js#L1790

You fire $q.reject but you never return it so you can't catch the promise discovered this when route got resolved even when server returned an error

VasilioRuzanni commented 9 years ago

@dani3l Thanks for the catch! Will take a look. Thanks!

VasilioRuzanni commented 9 years ago

@dani3l Fixed, feel free to reopen or create another one if there are any related issues.

dani3l commented 9 years ago

cool. thanks :)