search

Vaskivskyi / asusrouter

API wrapper for communication with ASUSWRT-powered routers using HTTP protocol
Apache License 2.0
66 stars 8 forks source link

[Bug] Inconsistency between documentation and code: 'hostname' vs 'host' parameter #541

Open mohsinalipro opened 1 month ago

mohsinalipro commented 1 month ago

The problem

There's an inconsistency between the documentation and the actual implementation regarding the parameter name for the router's address in the AsusRouter class. The documentation shows 'hostname' in the example, but the actual implementation uses 'host'. This causes confusion and errors when trying to use the library as per the documentation.

Python version

Python 3.10.12

Your device model

RT-AC68U

Firmware type

Merlin

Firmware version

386.13

Vaskivskyi commented 1 month ago

Hello, @mohsinalipro, both the dev and the main branches of the repository have AsusRouter class defined with a hostname argument.

https://github.com/Vaskivskyi/asusrouter/blob/331be1d178fe8f2b00b037d2dd50743475396cb3/asusrouter/asusrouter.py#L79-L89

In which part of the code did you find host?