search

VasuDevrani / artifact-explorer-oras

6 stars 2 forks source link

feat: download file modal #54

Closed VasuDevrani closed 1 year ago

VasuDevrani commented 1 year ago

issue #44

image image
qweeah commented 1 year ago

LGTM with suggestions: give a default name to the to-be-downloaded blob like sha256-8b764df1c1fec0a29011cdf05ec9b03dbcc40888c07a23f6e6970c874c664de1

VasuDevrani commented 1 year ago

LGTM with suggestions: give a default name to the to-be-downloaded blob like sha256-8b764df1c1fec0a29011cdf05ec9b03dbcc40888c07a23f6e6970c874c664de1

Default name is file.json or file.tar right now (if no filename entered)

qweeah commented 1 year ago

We should also add the download button to table view, where we can provide file name properly from the annotations.

@VasuDevrani what do you think?

qweeah commented 1 year ago

Let's merge this and continue the discussion in a new issue.