search

Vatsim-Scandinavia / controlcenter

Training Management System created by VATSIM Scandinavia
https://docs.vatsca.org/controlcenter/
GNU General Public License v3.0
16 stars 14 forks source link

Change `controllers` array to `roster_members` in division roster api #880

Open mufassilyasir opened 3 months ago

mufassilyasir commented 3 months ago

I may have not ran the command locally, so please do @blt950 😅

This closes #877

blt950 commented 3 months ago

I tried to run it locally @mufassilyasir but I get some server errors.


Syncing roster with Division API...
Adding new members to roster...
Failed to add member 10000004 to roster: Server Error
Failed to add member 10000051 to roster: No query results for model [App\Models\User] 10000051
Failed to add member 10000096 to roster: No query results for model [App\Models\User] 10000096
Failed to add member 10000201 to roster: No query results for model [App\Models\User] 10000201
Failed to add member 10000022 to roster: No query results for model [App\Models\User] 10000022
Failed to add member 10000003 to roster: Server Error
Failed to add member 10000002 to roster: Server Error
Failed to add member 10000077 to roster: No query results for model [App\Models\User] 10000077
Failed to add member 10000008 to roster: No query results for model [App\Models\User] 10000008
Removing members from roster...
Syncing roster with Division API completed.```

Those query model errors are fine, as they're just user who doesn't exist in your test env.
mufassilyasir commented 3 months ago

@blt950 Did you run the test with core-dev or core (prod)?

If on the dev version - please do run it on prod

blt950 commented 3 months ago

@mufassilyasir It's in the test env, so I run it for core-dev indeed. You want me to test dev users (1000001-10) on the prod env instead? I don't really want to make an release just to test this on prod-data, to find out something fails 😅

mufassilyasir commented 3 months ago

I'll get back to you when I can regarding testing in the dev env.

I don't know why I am not getting notifications on this PR...

blt950 commented 1 week ago

I'll get back to you when I can regarding testing in the dev env.

I don't know why I am not getting notifications on this PR...

Any update on this one?