search

Vatsim-Scandinavia / handover

Central Login Service created by VATSIM Scandinavia
https://handover.vatsim-scandinavia.org
GNU General Public License v3.0
4 stars 3 forks source link

Invalid access_token returns HTML instead of JSON #65

Closed blt950 closed 1 year ago

blt950 commented 2 years ago

Issue is that our user data endpoint sends the HTML login form when the access_token is invalid, where it should return JSON (e.g. status=403 {"message": "unauthorized"}) that can be parsed into an array.

I believe we need to check if the agent is an API that needs JSON response or a user that needs the front-end rendered if it's the one in LoginController causing this.

Could be also that this is correct return, as we're relaying VATSIM Connect data?

blt950 commented 1 year ago

This seems to be something from VATSIM Connect instead, we'll keep this open until Invision fixes this issue on their side.

blt950 commented 1 year ago

Invision still haven't fixed it, probably never going to either in this speed.

blt950 commented 1 year ago

Closing this as it's not really a Handover issue, and Invision need to get their shit together anyway (they still haven't).