search

Vauryx / advancedspelleffects

This module will use Sequencer, Tagger, JB2A spell effects and socketlib to create advanced spell functionality without relying on finicky macros to do the heavy lifting.
Other
19 stars 12 forks source link

Spiritual Weapon not getting all JB2A Spiritual Weapons #109

Open ReAcTiOnN77 opened 2 years ago

ReAcTiOnN77 commented 2 years ago

spiritualWeapon.js.zip

Had issues with what was available form JB2A catalouge and your module in reference to spritual weapon reworked your spiritualWeapon.js to implement more weapons and colours. Not the most elegant coding but works hoping you can use or rework it into the overall module.

Vauryx commented 2 years ago

Oh thanks for this! any chance you could submit this as a PR? This is good timing as I am in the middle of a massive rework and was going to be adding in more spiritual weapon options anyway. Appreciate your efforts!

ReAcTiOnN77 commented 2 years ago

I'm quite new to GitHub so I think I did the PR correctly

Vauryx commented 2 years ago

Hey, appreciate the work you put it into the request! Unfortunately I can't add it in with the attacks of the weapons not working at all anymore. Edit: To be clear, the new weapons you add in don't need to have the attack animations like the sword and mace do - but the sword and mace animations that are there do need to stay

ReAcTiOnN77 commented 2 years ago

hey mate, yep I can rectify that, ill do it tonight after work.

Edit: Reworked it and tested thoroughly should be what you're after now I hope.

Vauryx commented 2 years ago

thanks! I'll get it merged in and released with the big midi update.