Vauryx / advancedspelleffects

This module will use Sequencer, Tagger, JB2A spell effects and socketlib to create advanced spell functionality without relying on finicky macros to do the heavy lifting.
Other
19 stars 12 forks source link

[v10 beta] Damage application missing on Magic Missile #127

Open Seamonster73 opened 1 year ago

Seamonster73 commented 1 year ago

Magic Missile seems to mostly work, with targeting and the animation working fine. However, the resulting damage card(s) seem to have a minor issue:

(Note: I have MidiQOL installed, which may be conflicting here)

1 - Hits generate multiple damage cards (one per dart), followed by a final summary screen. The final 'damage summary' screen doesn't allow for the application of damage to the target(s): image (I may be misremembering, but I thought damage used to be applicable from this summary card alone)

2 - This isn't a bug but more a suggestion (so feel free to ignore), but due to the prevalence of modules like MidiQOL it may be worth adding something to the wiki to highlight that Midi's 'late targeting' feature conflicts with ASE's Magic Missile. With that switched on, Midi cuts in and wants the user to target a single token, which then prevents ASE's 'select multiple targets' screen from triggering. Switching this option off allows MM to run fine (with the possible exception of point 1 above).

Vauryx commented 1 year ago

MIDI-QOL shouldn't conflict, it's a required module for ASE. Could you export your MIDI settings and send them my way? Damage should be getting applied according to your MIDI settings. Generating one card per dart is normal. I'm trying to figure out a way to avoid that, but right now due to how ASE uses MIDI its expected. The late damage application was something I didn't know about. I'll add in that warning thanks!

Seamonster73 commented 1 year ago

fvtt-midi-qol-settings.json.zip

Here's my settings file.

Seamonster73 commented 1 year ago

One other minor question re this spell - Should all players (or at least the GM) see the target markers the casting player selects for the three darts? I thought it did previously but may be misremembering as it's ages since I last used it (it doesn't appear to do that currently in my setup).

Vauryx commented 1 year ago

ah that is a bug then - all players should see the markers