Vauryx / advancedspelleffects

This module will use Sequencer, Tagger, JB2A spell effects and socketlib to create advanced spell functionality without relying on finicky macros to do the heavy lifting.
Other
19 stars 12 forks source link

[v10 beta] Thunderstep-midi compatibility stuff #134

Open MrPotatoZed opened 1 year ago

MrPotatoZed commented 1 year ago

I'm seeing two relatively minor compatibility issues with thunderstep, both show up only with midi active:

  1. After casting within 5ft of a friendly token and selecting whether to take a friend it allows you to teleport. It then gives you the same friend selection box again and allows a second teleport. The second selection box shows all friendlies who were within 5ft before the first teleport and friendlies do teleport when selected in the second selection box regardless of how far away they are at the time of the second teleport. Friendly tokens not taken along for the first teleport but selected on the second move as far as the teleporting token and in the same direction but move from their starting position so they don't end up next to the teleporting token. Disabling midi fixes the behavior. Simply making both selections of who to take before picking a teleport destination works around the issue.
  2. After picking the destination for teleporting without a friendly token within 5ft the dm/player is left on the measurement controls. Not a big deal but I foresee briefly confused players. This does not occur when teleporting within 5 ft of a friendly token. When teleporting within 5ft of a friendly after selecting the destination the dm/player is left with token controls selected. Disabling midi fixes the behavior.

Tested on v10.291, 5e 2.1.2, in chrome on the forge. Only ASE+ dependencies + midi active. Several deprecation warnings but no errors in console.