Vauxoo / addons-vauxoo

All our modules related to developments that solves generic issues on Odoo, or that solve internal problems on Odoo Core, if something is here, maybe it is solving an issue in your company, try it and report what you see.
http://www.vauxoo.com
193 stars 288 forks source link

[9.0] Error installing mrp_production_analytic_acc #1093

Closed kmlew closed 4 years ago

kmlew commented 7 years ago

Hi!

I'm using Odoo version 9.0c-20160620 (Community Edition). While installing mrp_production_analytic_acc, I encounter the following below. Please let me know if there's a fix for it.

mrp account analytics odoo

zaoral commented 7 years ago

Hi @kmlew Thank you for reporting.

It seems that this module was created in 8.0 and do not have any problem so far. Since you are using 9.0 version maybe this is a new restriction for this particular version.

I make a quick review and modify the view code in order to avoid this error just making the xpath more simple. You can review the change made in #1094: Please you can try to install mrp_production_analytic_acc module with the change made and let me know if the error disappears

kmlew commented 7 years ago

Hello @zaoral,

There are a few more lines similar to the one you changed further which also causes the installation to fail. I have manually corrected them in my copy and it installs. Unfortunately, I am new to GitHub and am not sure how to share my changes. Perhaps you can give me some tips?

KM

zaoral commented 7 years ago

Hi @kmlew Yes, you can:

You can do it yourself following the vauxoo's contribution guide [here}(https://github.com/Vauxoo/addons-vauxoo/blob/8.0/CONTRIBUTING.md#how-add-a-new-feature) If you feel comfortable using git commands:

  1. from github fork vauxoo/addons-vauxoo to your user account.
  2. clone and configure locally your new repository kmlew/addons-vauxoo
  3. create a new branch with the changes, commit and then push your new branch to kmlew/addons-vauxoo. 4 Now you can create the pull request with your change to vauxoo/addons-vauxoo repository, just go to the pull request tab, and click in the create Pull Request button. image
  4. Now you need to indicate where do you want to make the new add (the merge) and from what branch to add the new changes (your branch in kmlew/addons-vauxoo). In order to do this you need to first click in the link compare across forks image

    Then you can specific version that you are going to add the PR to addons-vauxoo 9.0 branch, This is important. And in the Head Fork found your kmlew/addons-vauxoo and the new branch you uploaded in the step (3)

    image

Now only click the create pull request and is ready.

If not. you can also send us the patch file with the diff of the change you make in order to fix all the errors. and we can applied creating the branch and the PR.

Best Regards

kmlew commented 7 years ago

Let me try that first! ;)

Thanks for your help. By the way, after installing, I encountered another issue. I have raised it already.

Cheers! km

On Oct 28, 2016, at 07:43, Katherine Zaoral [Vauxoo] notifications@github.com wrote:

Hi @kmlew https://github.com/kmlew Yes, you can:

You can do it yourself following the vauxoo's contribution guide [here}(https://github.com/Vauxoo/addons-vauxoo/blob/8.0/CONTRIBUTING.md#how-add-a-new-feature https://github.com/Vauxoo/addons-vauxoo/blob/8.0/CONTRIBUTING.md#how-add-a-new-feature) If you feel comfortable using git commands:

from github fork vauxoo/addons-vauxoo to your user account. clone and configure locally your new repository kmlew/addons-vauxoo create a new branch with the changes, commit and then push your new branch to kmlew/addons-vauxoo. 4 Now you can create the pull request with your change to vauxoo/addons-vauxoo repository, just go to the pull request tab, and click in the create Pull Request button. https://cloud.githubusercontent.com/assets/7593953/19790207/103629ee-9c7c-11e6-8097-1072f372f255.png Now you need to indicate where do you want to make the new add (the merge) and from what branch to add the new changes (your branch in kmlew/addons-vauxoo). In order to do this you need to first click in the link compare across forks https://cloud.githubusercontent.com/assets/7593953/19790227/45ff2256-9c7c-11e6-9425-315a9a7da642.png Then you can specific version that you are going to add the PR to addons-vauxoo 9.0 branch, This is important. And in the Head Fork found your kmlew/addons-vauxoo and the new branch you uploaded in the step (3)

https://cloud.githubusercontent.com/assets/7593953/19790264/8817d66a-9c7c-11e6-80a6-eb759c5538da.png Now only click the create pull request and is ready.

If not. you can also send us the patch file with the diff of the change you make in order to fix all the errors. and we can applied creating the branch and the PR.

Best Regards

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Vauxoo/addons-vauxoo/issues/1093#issuecomment-256808702, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ3oKjaCK0EUytk6KZOe_zmdwlxUQlLBks5q4UVMgaJpZM4KiH-1.

kmlew commented 7 years ago

All done. Hope I didn't break anything. Please let me know if it works.

KM

hbto commented 7 years ago

@kmlew

All done. Hope I didn't break anything. Please let me know if it works.

Where did you push your changes?

Regards

kmlew commented 7 years ago

1096