search

Vauxoo / addons-vauxoo

All our modules related to developments that solves generic issues on Odoo, or that solve internal problems on Odoo Core, if something is here, maybe it is solving an issue in your company, try it and report what you see.
http://www.vauxoo.com
193 stars 288 forks source link

[MIG] Migration of account_asset_move_check 8.0 --> 11.0 #1280

Closed umiphos closed 6 years ago

umiphos commented 6 years ago

Dummy for this change

https://git.vauxoo.com/vauxoo/lodi/merge_requests/17

umiphos commented 6 years ago

@dsabrinarg can you please test if this PR do what it's expected of it? thanks in advance

dsabrinarg commented 6 years ago

@umiphos please link the dummy to this repo here

umiphos commented 6 years ago

@dsabrinarg this is the dummy for this migration https://git.vauxoo.com/vauxoo/lodi/merge_requests/17

dsabrinarg commented 6 years ago

@umiphos please solve the conflicts, weird thing, I tested again this today and the last point was working, I will merge and after that if on the test customer environment this fails I will check and assign the fix.

dsabrinarg commented 6 years ago

@josemoralesp functional review 👍

dsabrinarg commented 6 years ago

@umiphos may you please check the comments from Jose and fix asap in order to be able of finish this task?.

dsabrinarg commented 6 years ago

This is ready for review @umiphos @josemoralesp ?

umiphos commented 6 years ago

yes @dsabrinarg I updated the dummy for tests https://git.vauxoo.com/vauxoo/lodi/merge_requests/17

@josemoralesp do you agree with the changes?

umiphos commented 6 years ago

@josemoralesp as talked via in person, I added an automated action, it's working as I expected, can you please validate if that that's what you asked?

dsabrinarg commented 6 years ago

Nice, the current behaviour due to the automated action is very nice @umiphos @josemoralesp 👍