Vauxoo / addons-vauxoo

All our modules related to developments that solves generic issues on Odoo, or that solve internal problems on Odoo Core, if something is here, maybe it is solving an issue in your company, try it and report what you see.
http://www.vauxoo.com
193 stars 288 forks source link

[MIG] account_invoice_line_asset_category_required: Migrated to v11.0 #1284

Closed luiseevaquer closed 6 years ago

luiseevaquer commented 6 years ago

dummy LODI: https://git.vauxoo.com/vauxoo/lodi/merge_requests/18

dsabrinarg commented 6 years ago

@lescobarvx may you please check this message, let's re-write that message please to say something like:

                raise ValidationError(_(
                    "Asset policy is set to 'Never' for the account '%s %s' but "
                    "the account invoice line of description '%s'"
                    "have this asset category set: %s" % (
                        line.account_id.code, line.account_id.name,
                        line.name, line.[asset category name field])))
dsabrinarg commented 6 years ago

@lescobarvx for this case to, just a small change: raise ValidationError(_( "Asset policy is set to 'Always' for the account '%s %s' but " "the asset category is missing in the account invoice " "line with description '%s'." % ( line.account_id.code, line.account_id.name, line.name)))

dsabrinarg commented 6 years ago

Functional tests 👍 please if this LGTY merge this asap @josemoralesp