Vauxoo / addons-vauxoo

All our modules related to developments that solves generic issues on Odoo, or that solve internal problems on Odoo Core, if something is here, maybe it is solving an issue in your company, try it and report what you see.
http://www.vauxoo.com
193 stars 288 forks source link

[REF] product_cost_usd: standard_price_usd as compute field #1287

Closed suniagajose closed 4 years ago

suniagajose commented 6 years ago

Summary

The field Cost in USD, now, is computed getting the price in USD recordered in vendor pricelist. In this way, is not necessary have constraint to ensure that at least a vendor pricelist in USD currency is loaded, if it isn't registered in the vendor pricelist, then, will be 0.0.

Preview

d3694770 rear inner cover duplex unit mp2550sp - odoo

d3694770 rear inner cover duplex unit mp2550sp - odoo 1

luisg123v commented 4 years ago

Hi @suniagajose,

Is this still outstanding?

suniagajose commented 4 years ago

@luisg123v

is a improvement but need to be approved by customers that use the module on this version...

maybe the right way is merge in v13.0 or a future odoo version where this module is not yet implemented by a customer

luisg123v commented 4 years ago

Hi @suniagajose,

I don't think this will be used, given that it's been more than two years from its creation now. Hence, I'm going to close this PR.

I'll take this into account if this module gets ever migrated to v12 or above, though.

Of course, feel free to reopen it if you need it in the future, or if you consider it should remain opened.