search

Vauxoo / addons-vauxoo

All our modules related to developments that solves generic issues on Odoo, or that solve internal problems on Odoo Core, if something is here, maybe it is solving an issue in your company, try it and report what you see.
http://www.vauxoo.com
193 stars 288 forks source link

[MIG] email_show_only_changes: Migration to 12.0 #1299

Closed hugho-ad closed 5 years ago

hugho-ad commented 5 years ago

@moylop260

could you review this please?

hugho-ad commented 5 years ago

@moylop260 Done

hugho-ad commented 5 years ago

@moylop260

About the pr to an oca project, I was thinking in server-tools, what do u think?

Also, Why this module can't be only at addons-vauxoo?

Regards!

moylop260 commented 5 years ago

What about https://github.com/OCA/server-ux?

Let's to create the PR to server-ux and wait feedback about.

Let me know the PR.

Also, Why this module can't be only at addons-vauxoo?

Because exists a community that we are supporting and they are supporting us.

moylop260 commented 5 years ago

Another reason is that addons-vauxoo is not executing tests, then if we find a home in OCA for this module we will have a community supporting it, we will have a coverage report, runbot, travis tests, lints... and so on.

hugho-ad commented 5 years ago

@moylop260 Cool! thanks for the feedback, I'll make the pr to server-ux

Regards!

hugho-ad commented 5 years ago

PR https://github.com/Vauxoo/server-ux/pull/3

moylop260 commented 5 years ago

Please, uses https://github.com/OCA/server-ux project instead of Vauxoo one. Like my last comment: https://github.com/Vauxoo/addons-vauxoo/pull/1299#issuecomment-431886623

hugho-ad commented 5 years ago

https://github.com/OCA/server-ux/pull/40