search

Vauxoo / addons-vauxoo

All our modules related to developments that solves generic issues on Odoo, or that solve internal problems on Odoo Core, if something is here, maybe it is solving an issue in your company, try it and report what you see.
http://www.vauxoo.com
193 stars 288 forks source link

[ADD] invoice_split: Add module to split customer invoices #1300

Closed luisg123v closed 5 years ago

luisg123v commented 5 years ago

This module allows to split a customer invoice, so the customer may pay a percentage of the invoice amount and, optionally, create a new invoice to pay the remaining amount later.

For more info, see the README file.

Dummy MR: https://git.vauxoo.com/absa/absa/merge_requests/75

JulioSerna commented 5 years ago

@luisg123v @yaniaular

Is there an UH related to this PR?

luisg123v commented 5 years ago

Hi @JulioSerna
This is related to the task#27639

luisg123v commented 5 years ago

@yaniaular
This is ready for review.

yaniaular commented 5 years ago

@luisg123v Add translations please

luisg123v commented 5 years ago

Done @yaniaular, translations were included.

luisg123v commented 5 years ago

@yaniaular
All comments were applied or answered.

Note: For now, this is red because of this issue

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 93.939% when pulling 39720a00c4dd510d6fe49796b13367021bdd09c3 on vauxoo-dev:12.0-add_module_split_invoice-luisg into 136c03539c2fd7628f9092cdcce3a5f246dca9d4 on Vauxoo:12.0.

luisg123v commented 5 years ago

@yaniaular
This is not red anymore.

yaniaular commented 5 years ago

@luisg123v The taxes in the splited invoices are not recalculating, could you check if this method is called correctly in your method? please

luisg123v commented 5 years ago

@yaniaular done.

I also improved the README and docstrings to explain te case of invoicing three units and splitting by 50%, where 1.5 of any product will be invoiced, even if it's not possible in practice.

luisg123v commented 5 years ago

We found this module to not be generic enough to be here (at least for now), hence I'm closing this.