[IMP] account_invoice_change_currency: Migration & Improvements

Vauxoo / addons-vauxoo

All our modules related to developments that solves generic issues on Odoo, or that solve internal problems on Odoo Core, if something is here, maybe it is solving an issue in your company, try it and report what you see.

http://www.vauxoo.com

193 stars 288 forks source link

[IMP] account_invoice_change_currency: Migration & Improvements #1303

Closed hbto closed 5 years ago

hbto commented 5 years ago

custom_rate: has been refactored, no longer a computed field. Now includes a default which seeks the rates between company currency and index based currency.
index_based_currency_id: a new field in the company, and related to invoices. For reporting purposes.

On aml's

index_based_currency_rate: was added and is recorded from invoice at date of invoice, for reporting purposes.
custom_rate: was added and is recorded with custom_rate in the invoice

hugho-ad commented 5 years ago

FYI https://github.com/OCA/account-invoicing/tree/12.0/account_invoice_change_currency

we should move this changes to above repo

hbto commented 5 years ago

@nhomar please advise on @hugho-ad comment above.

Regards

yaniaular commented 5 years ago

@nhomar could you review this PR?

hugho-ad commented 5 years ago

@hbto

Is this finished? I would like to open a pr to Oca/account-invoicing repo Here I have a pr with the cherry-picks from this repo to the oca one https://github.com/Vauxoo/account-invoicing/pull/1

Regards!

hbto commented 5 years ago

@hugho-ad I think the work can be pushed on the wild and expect for the reviews of peers to make improvements

Regards

yaniaular commented 5 years ago

@moylop260 @josemoralesp could you review and merge this?

moylop260 commented 5 years ago

This module is really migrated to 12.0 in the OCA repo: https://github.com/OCA/account-invoicing/tree/12.0/account_invoice_change_currency

hbto commented 5 years ago

@moylop260 we were told by @nhomar to make this changes and simplify the module like the way it was done.

@nhomar, please have a say in here.

Regards.

moylop260 commented 5 years ago

FYI I just tested the module from runbot https://runbot.odoo-community.org/runbot/95/12.0

moylop260 commented 5 years ago

A good developer creates. A better developer re-use.

If you prefer to creates something that is created before, then use the customer project or localization one. Using a generic one like addons-vauxoo could make conflicts with the OCA apps registered on odoo.com and deploying modules with the same name.

In fact, in the help of the fields you are talking about MX needs, and this project is not for MX.

Then there are 2 conflicts to merge it for this project.

yaniaular commented 5 years ago

@moylop260 This module will be used probably in our vauxoo instance by @nhomar. Then I think the better option is merge it in addons-vauxoo. Thus, We will change the name to the module for avoid problems with OCA.

moylop260 commented 5 years ago

I have another doubt about the flow to reconcile the XML of the CFDI for the SAT in the field xml.moneda and xml.tipo_cambio vs account_move_line

hugho-ad commented 5 years ago

@moylop260

I think this feature must only available for draft invoices, to avoid the issue you are pointing out, don't you think?

hbto commented 5 years ago

I have another doubt about the flow to reconcile the XML of the CFDI for the SAT in the field xml.moneda and xml.tipo_cambio vs account_move_line

Custom rate will only be a business fields in the invoice. for signing purposes the SAT rate is the one to be used in Invoice.

Regards

moylop260 commented 5 years ago

FYI the module to update currency and custom rate was migrated to 12.0 for OCA:

https://github.com/Vauxoo/account-invoicing/tree/12.0/account_invoice_change_currency

@hbto Could you use this one as dependency and continue with the module of account_index_based_currency?

yaniaular commented 5 years ago

@moylop260 do you have any idea about the error in the travis?

[Errno 2] No such file or directory: 'unbuffer': 'unbuffer'

moylop260 commented 5 years ago

Please, Could you rebase the branch? https://github.com/Vauxoo/addons-vauxoo/commit/74e1b1d6af404887378282d0bd53194a4e68b752

luisg123v commented 5 years ago

I will rebase this...

coveralls commented 5 years ago

Coverage remained the same at 32.967% when pulling 3dab6381b57d97665024c6bc2310e01202807ab2 on vauxoo-dev:12.0-account_invoice_change_currency-hbto into 74e1b1d6af404887378282d0bd53194a4e68b752 on Vauxoo:12.0.

yaniaular commented 5 years ago

@moylop260 @nhomar can you review and merge this?

moylop260 commented 5 years ago

Where are you using the module https://github.com/Vauxoo/account-invoicing/tree/12.0/account_invoice_change_currency?

yaniaular commented 5 years ago

@hbto You have comments here

yaniaular commented 5 years ago

@hbto Any news about this?

hbto commented 5 years ago

I think that we have make a new PR That module is not the same any longer

I have pushed the new changes.

hbto commented 5 years ago

@yaniaular

This PR https://github.com/Vauxoo/addons-vauxoo/pull/1316 supersedes this one