search

Vauxoo / addons-vauxoo

All our modules related to developments that solves generic issues on Odoo, or that solve internal problems on Odoo Core, if something is here, maybe it is solving an issue in your company, try it and report what you see.
http://www.vauxoo.com
193 stars 288 forks source link

[FIX] sale_margin_percentage: The subtotal price is set to zero #1336

Closed deivislaya closed 5 years ago

deivislaya commented 5 years ago

This occurs when placing a 100% discount on the sales order line, calculating the subtotal price at zero. This generates a division error by zero

This MR corrected fix #1335 in #1317 when the unit price is not found or the discount is equal to 100%

TODO

deivislaya commented 5 years ago

Hi @suniagajose

This MR is ready for review

suniagajose commented 5 years ago

Thanks @deivislaya

Please could you made a dummy PR for rico repo.

Regards,

deivislaya commented 5 years ago

@suniagajose

Ready, dummy instance rico and tanner

Regards

suniagajose commented 5 years ago

Thanks @deivislaya

@JulioSerna what do you think? can we merge this?

Regards,

suniagajose commented 5 years ago

ping @JulioSerna ...

Could you approve this MR? please.

Regards,

JulioSerna commented 5 years ago

👍