[MIG] account_refund_early_payment: Migrate to version 12.0

Vauxoo / addons-vauxoo

All our modules related to developments that solves generic issues on Odoo, or that solve internal problems on Odoo Core, if something is here, maybe it is solving an issue in your company, try it and report what you see.

http://www.vauxoo.com

193 stars 288 forks source link

[MIG] account_refund_early_payment: Migrate to version 12.0 #1342

Closed luisg123v closed 5 years ago

luisg123v commented 5 years ago

The following changes were performed:

Bump version
Fix references to external IDs
Re-write tests. They didn't work probably from a long time ago, because they relied on workflows
Remove encoding and long license from headers, use short license only
Use plural for directories: wizard -> wizards
Move views for wizards to the wizards directory
Remove all redundant .po files, as their content was te same, only es.po was left
Migrate and update translation terms
Remove deprecated keys from manifest
Replace openerp by odoo on import statements and XML tags
Fix lints
Fix typos on the README
Small code clean-up

luisg123v commented 5 years ago

@moylop260 Could you check why MQT is failing here when installing apt dependencies?

CC @yaniaular

keylor2906 commented 5 years ago

Hello @luisg123v I also had a first approach of forwardporting this module from v11.0 to 12.0 on this PR https://github.com/Vauxoo/addons-vauxoo/pull/1337

keylor2906 commented 5 years ago

@yaniaular @moylop260 Could you please review/merge one of the migration PRs of early payment, I understand this module is needed on absa, but is also needed for macom

keylor2906 commented 5 years ago

@luistorresm This PR belongs to @luisg123v

luistorresm commented 5 years ago

@luisg123v

Could you review my last comment, please?

Regards

luisg123v commented 5 years ago

@luistorresm
Done. However, After reviewing all commits, I was only able to take down the number of commits from 61 to 58. For example, I tried to squash similar commits that fixes lints that were not just next to each oter, but when I tried to move them, conflicts popped up.

keylor2906 commented 5 years ago

@moylop260 @yaniaular Could you please review/merge this?