[IMP] partner_credit_limit: Improve the module for multicompany

Vauxoo / addons-vauxoo

All our modules related to developments that solves generic issues on Odoo, or that solve internal problems on Odoo Core, if something is here, maybe it is solving an issue in your company, try it and report what you see.

http://www.vauxoo.com

193 stars 288 forks source link

[IMP] partner_credit_limit: Improve the module for multicompany #1371

Closed edy1192 closed 4 years ago

edy1192 commented 4 years ago

For instances of multiple companies, the credit limit value or days of grace does not differentiate between company, so if the customer has a credit limit 100 with company A, that same value will be in the company B.
In some cases these values changes according to the company.
With this change the account.move.line are searched according to the company and additionally the credit limit fields and grace days now depend on the company.
Migration script to set the old values for the credit_limit and grace_payment_days fields.

Videos in the comments:

edy1192 commented 4 years ago

@luistorresm Could you check this, please?

Regards.

luistorresm commented 4 years ago

@JulioSerna @hbto

LGTM this module improve, what do you think?

Regards

hugho-ad commented 4 years ago

An extra LGTM :+1:

edy1192 commented 4 years ago

@hbto Could you check this, please?

Regards.

hbto commented 4 years ago

:+1:

luistorresm commented 4 years ago

@moylop260

Could you merge this PR, please?

Regards

edy1192 commented 4 years ago

@hugho-ad @moylop260 I applied the changes that you suggested! Could you check it please?

Regards.

hugho-ad commented 4 years ago

LGTM :+1:

edy1192 commented 4 years ago

Hi @moylop260 Could you review / merge this, please?

cc @hugho-ad

Regards

edy1192 commented 4 years ago

@moylop260 I applied the comments that you gave me in the meeting.

I will ask the team, customers with this module to make dummy MRs and test these changes.

Thanks for your advices.

@hugho-ad @luistorresm Thanks you too

😄

Regards.