search

Vauxoo / addons-vauxoo

All our modules related to developments that solves generic issues on Odoo, or that solve internal problems on Odoo Core, if something is here, maybe it is solving an issue in your company, try it and report what you see.
http://www.vauxoo.com
193 stars 288 forks source link

[FIX] partner_credit_limit: Add = to the validation condition #1406

Closed edy1192 closed 4 years ago

edy1192 commented 4 years ago

There is data demo with the value of the grace_payment_days field set to 999999, that value must be included.

Improve message that is displayed to the user when the constraint is executed, to show the value that is trying to save.

Screenshot from 2020-04-03 14-23-36

edy1192 commented 4 years ago

Hi @moylop260 @luisg123v Could you check this please?

In the previous PR, I forgot to put the = to the validation that moy asked me in the comment.

This caused a typ MR to be turning red in the tests because the demo data has 999999 set in the field.

But 999999 is a valid value.

Moy I have no issue / task for this PR, this was commented to me by @JulioSerna

Julio do you have a task for this?

Regards.

luisg123v commented 4 years ago

@edy1192 could you perform the cherry-pick of these fixes to v12, please?

luisg123v commented 4 years ago

@edy1192,

Could you forward-port this fix to v12, please?