[FIX] *: Lint and flake8 issues

Vauxoo / addons-vauxoo

All our modules related to developments that solves generic issues on Odoo, or that solve internal problems on Odoo Core, if something is here, maybe it is solving an issue in your company, try it and report what you see.

http://www.vauxoo.com

193 stars 288 forks source link

[FIX] *: Lint and flake8 issues #1423

Closed luisg123v closed 4 years ago

luisg123v commented 4 years ago

The following modules are fixed, one per commit:

account_anglo_saxon_stock_move
account_anglo_saxon_stock_move_purchase
account_anglo_saxon_stock_move_sale
account_asset_move_check
account_currency_tools
account_invoice_line_asset_category_required
account_move_line_production
mrp_workcenter_account_move
product_extended_segmentation
product_extended_segmentation_byproduct
purchase_third_validation
stock_cost_segmentation
stock_move_entries

Partially solves https://github.com/Vauxoo/addons-vauxoo/issues/1422

luisg123v commented 4 years ago

@moylop260,

what do you think about this change?

I know it's kind of big, but:

AFAIK none of these modules is used, they were migrated for the customer perfection, which won't be implemented anyway
Some of them currently don't work anyway.

CC @hugho-ad

luisg123v commented 4 years ago

@moylop260

And it's one commit per module, which will make easy to revert one of them if required

moylop260 commented 4 years ago

@hugho-ad @lescobarvx Could you check it, please?

hugho-ad commented 4 years ago

LGTM

luisg123v commented 4 years ago

@hugho-ad,

Do you have any other comment? Or can we merge this already?

hugho-ad commented 4 years ago

:+1: