[ADD] account_chatter: Allows to record changes in CoA, journals and …

Vauxoo / addons-vauxoo

All our modules related to developments that solves generic issues on Odoo, or that solve internal problems on Odoo Core, if something is here, maybe it is solving an issue in your company, try it and report what you see.

http://www.vauxoo.com

193 stars 288 forks source link

[ADD] account_chatter: Allows to record changes in CoA, journals and … #1459

Closed randall-vx closed 3 years ago

randall-vx commented 3 years ago

…account moves.

CoA:

AM:

Journal:

coveralls commented 3 years ago

Coverage increased (+1.4%) to 58.589% when pulling 3b6ecead0e37327fa6786dc519a9ee209f523756 on vauxoo-dev:12.0-account-chatter-dev-randallvx into bdeb3fa257fbcb85a04ef56b3665447f4f7ae845 on Vauxoo:12.0.

randall-vx commented 3 years ago

@luisg123v could you review this PR please ?

Regatas,

luisg123v commented 3 years ago

Comment https://github.com/Vauxoo/addons-vauxoo/pull/1459#pullrequestreview-507906734 is pending and IMHO easy to apply, just copy images into static/src/description

randall-vx commented 3 years ago

Comment #1459 (review) is pending and IMHO easy to apply, just copy images into static/src/description

Done ! Please check !

luisg123v commented 3 years ago

Hi @randall-vx,

Sorry if I wasn't clear enough. I noticed you copied screenshots on the suggested directory. However, that is not enough for those images to be shown in the module's description. You have to reference them in the README, for instance:

https://github.com/Vauxoo/addons-vauxoo/blame/bdeb3fa257fbcb85a04ef56b3665447f4f7ae845/internal_transfer_with_agreed_amount/README.rst#L10

randall-vx commented 3 years ago

Hi @randall-vx,

Sorry if I wasn't clear enough. I noticed you copied screenshots on the suggested directory. However, that is not enough for those images to be shown in the module's description. You have to reference them in the README, for instance:

https://github.com/Vauxoo/addons-vauxoo/blame/bdeb3fa257fbcb85a04ef56b3665447f4f7ae845/internal_transfer_with_agreed_amount/README.rst#L10

Your example doesn't work...

PR it's ready to merge now.

luisg123v commented 3 years ago

Hi @randall-vx,

I understand. I will fix it later post-merge.

luisg123v commented 3 years ago

@randall-vx next time, remember to squash your commits.