search

Vauxoo / addons-vauxoo

All our modules related to developments that solves generic issues on Odoo, or that solve internal problems on Odoo Core, if something is here, maybe it is solving an issue in your company, try it and report what you see.
http://www.vauxoo.com
193 stars 288 forks source link

[MIG] controller_report_xls: Migration to 11.0 #1466

Closed goliveirab closed 3 years ago

goliveirab commented 3 years ago

DUMMY: https://git.vauxoo.com/vauxoo/quebec/-/merge_requests/84

hugho-ad commented 3 years ago

@goliveirab this is ready?

Stefan already approved it :+1:

hugho-ad commented 3 years ago

@goliveirab @luisg123v

Stefan approve it

@goliveirab it's ready?

LGTM btw

goliveirab commented 3 years ago

@goliveirab @luisg123v

Stefan approve it

@goliveirab it's ready?

LGTM btw

Yes!

hugho-ad commented 3 years ago

@goliveirab

Just missing to attend Luis's comments about commit messages, could you please do it?

regards!

goliveirab commented 3 years ago

@hugho-ad @luisg123v

I just split the commit.... could you please check this?

Regards.

luisg123v commented 3 years ago

@goliveirab Note for future changes: ideally, the commit migrating the module should've gone first, as the other one depends on it.