search

Vauxoo / addons-vauxoo

All our modules related to developments that solves generic issues on Odoo, or that solve internal problems on Odoo Core, if something is here, maybe it is solving an issue in your company, try it and report what you see.
http://www.vauxoo.com
193 stars 288 forks source link

[IMP] account_move_report: Add names to XML elements #1473

Closed luisg123v closed 3 years ago

luisg123v commented 3 years ago

This is to be able to inherit the report on a deterministic manner.

luisg123v commented 3 years ago

@moylop260 @hbto @hugho-ad,

Could you review, please?

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 68.378% when pulling bc06c6c9de80cf28a6ac87e76d7f612712d50631 on vauxoo-dev:13.0-account_report_element_names-luisg into 23c454e941aa1731083269fe95dd68da81f368d1 on Vauxoo:13.0.

moylop260 commented 3 years ago

Do you have a dummy MR?

luisg123v commented 3 years ago

No, but I need this for the migration of vauxoo. Without this, I'm not able to install the module vauxoo, and I managed to install it with this..

moylop260 commented 3 years ago

Without this, I'm not able to install the module vauxoo

So, Can you create a dummy to vx instance?

In order to check that with this you are able to install the module vauxoo.

Is not?

luisg123v commented 3 years ago

FYI AFAIK this module is not used yet in v13, it was migrated straight to 14.0. When I re-initialized the branches 13.0 & 14.0, I followed the standard migration process and migrated it to v13 and re-migrated it to v14 (on https://github.com/Vauxoo/addons-vauxoo/pull/1455 and https://github.com/Vauxoo/addons-vauxoo/pull/1456, respectively).

moylop260 commented 3 years ago

I didn't get you but the MR looks safe for me

So, you can merge it if you consider it

hbto commented 3 years ago

no vx instance in 13.0

only vx instance in 14.0

@Moises Lopez Vauxoo moylop260@vauxoo.com

Regards. Quien suscribe,

Humberto Arocha

On Thu, Dec 17, 2020 at 3:52 PM moylop260 notifications@github.com wrote:

I didn't get you but the MR looks safe for me

So, you can merge it if you consider it

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Vauxoo/addons-vauxoo/pull/1473#issuecomment-747724342, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZ67OTAZM6ZFCJR5XJ6GY3SVJ4TDANCNFSM4VAGELMQ .

hbto commented 3 years ago

Without this, I'm not able to install the module vauxoo

So, Can you create a dummy to vx instance?

In order to check that with this you are able to install the module vauxoo.

Is not?

@luisg123v I would suggest to use a v13.0 project to make a dummy.

Regards.

luisg123v commented 3 years ago

here the MR where I managed to install this module. Pay attention to the last commit, which is the dummy one.

luisg123v commented 3 years ago

As @moylop260 commented, this change is safe enough, and it's working on the dummy MR. So I'll merge it.