search

Vauxoo / addons-vauxoo

All our modules related to developments that solves generic issues on Odoo, or that solve internal problems on Odoo Core, if something is here, maybe it is solving an issue in your company, try it and report what you see.
http://www.vauxoo.com
193 stars 288 forks source link

[MIG] stock_by_warehouse: Migration to 14.0 #1498

Closed hugho-ad closed 3 years ago

CarmenMiranda commented 3 years ago

Hi @hugho-ad It looks good to me, however, I'm not completely familiar with @api.depends_context (I'm still working with v12) so if there is someone else that is more familiar with them I would suggest you check it out

Something that I saw is that the following commits from 12 (which are some improvements) are missing :

hugho-ad commented 3 years ago

@CarmenMiranda

I'm migrating from v13.0, that is why the improvement commits you mention are not here

I could made the forward port in a separated MR

about depends_context that changes were made when we migrate the module to v13.0, I already request @deivislaya reviewing.

CarmenMiranda commented 3 years ago

@CarmenMiranda

I'm migrating from v13.0, that is why the improvement commits you mention are not here

I could made the forward port in a separated MR

about depends_context that changes were made when we migrate the module to v13.0, I already request @deivislaya reviewing.

Oki, besides that LGTM 👍🏼

hugho-ad commented 3 years ago

@moylop260 could you review pls

moylop260 commented 3 years ago

I think odoo v14.0 doesn't need all the workaround that I used here for v12.0

But even it is working so 👍

deivislaya commented 3 years ago

LGTM :+1:

Good job!!

Regards

luisg123v commented 3 years ago

@hugho-ad remember to remove branches after merging.