search

Vauxoo / addons-vauxoo

All our modules related to developments that solves generic issues on Odoo, or that solve internal problems on Odoo Core, if something is here, maybe it is solving an issue in your company, try it and report what you see.
http://www.vauxoo.com
193 stars 288 forks source link

[FIX] default_warehouse_from_Sale_team: Don't overwrite team nor warehouse i#16738 #1510

Closed luisg123v closed 2 years ago

luisg123v commented 2 years ago

When the partner is changed in a sale order, the current user's sales team and warehouse should have priority over other ones.

Dummy MR: https://git.vauxoo.com/vauxoo/typ/-/merge_requests/885

luisg123v commented 2 years ago

@moylop260 @CarmenMiranda

Could you review, please?

CC @hugho-ad @desdelinux

moylop260 commented 2 years ago

@hugho-ad @CarmenMiranda

I think this PR needs a functional review since that I'm not in context of this change

Check if it will not raise permissions errores removing sudo

CarmenMiranda commented 2 years ago

@moylop260 @CarmenMiranda

Could you review, please?

CC @hugho-ad @desdelinux

Technically LGTM 👍🏼 , but I agree that needs functional review 🙈

luisg123v commented 2 years ago

Permission errors shouldn't occur because it's reading current user's sales team. All users have permission to read users and internal users have permissions to read sales teams

If a permission error occurs, it would need to be checked separately, because you need access to read your own sales team to be able to use it.

luisg123v commented 2 years ago

Thanks you all.