Closed xmglord closed 4 months ago
@xmglord task in the MR description please
Please, test your PR functionally. This error happened when I tried to open a sale order line
Please, test your PR functionally. This error happened when I tried to open a sale order line
Actually, this error comes from stock_by_warehouse, it is required functional review previous merging cc @luisg123v @desdelinux
Use this as example https://github.com/odoo/odoo/blob/ce3b096de7a0dcbf2bc8387d0c17ac3d320a7ec4/addons/mail/static/src/js/onchange_on_keydown.js#L69, the fix in other PR and be sure to test in the both modules.
@luisg123v please review but don't merge until @rolandojduartem give his functional review.
No, the changes on stock_by_warehouse must be other PR, that is a fix, not a migration, you can rebase over that PR for functional review, but I do not think is a good idea mix changes in the same PR
This MR is not rebased over !1651, so it fails
This MR is not rebased over !1651, so it fails
I already rebase but for some reason when installing this modules the widget fails.
Hello, what are we missing here? @luisg123v @xmglord
is this ready for functional review?
@rolandojduartem yes, this is ready for functional review.
I am going to test it then
I think it is not working as I expected, see the sale order, I did not activate the button and the widget was loaded at the beggining, could you check it?
Alsoo llok the button, the widget and the button are so close
@rolandojduartem I already fix the space between the widget and the button, please review again.
Friendly Reminder @rolandojduartem
Functionally and technically LGTM @luisg123v
@isaako34 and @rolandojduartem please review.