Vauxoo / addons-vauxoo

All our modules related to developments that solves generic issues on Odoo, or that solve internal problems on Odoo Core, if something is here, maybe it is solving an issue in your company, try it and report what you see.
http://www.vauxoo.com
193 stars 288 forks source link

[MIG] stock_by_warehouse_sale: Migration to 17.0 T#79454 #1643

Closed xmglord closed 4 months ago

xmglord commented 6 months ago

@isaako34 and @rolandojduartem please review.

rolandojduartem commented 6 months ago

@xmglord task in the MR description please

rolandojduartem commented 6 months ago

Please, test your PR functionally. This error happened when I tried to open a sale order line

image

rolandojduartem commented 6 months ago

Please, test your PR functionally. This error happened when I tried to open a sale order line

image

Actually, this error comes from stock_by_warehouse, it is required functional review previous merging cc @luisg123v @desdelinux

rolandojduartem commented 6 months ago

Use this as example https://github.com/odoo/odoo/blob/ce3b096de7a0dcbf2bc8387d0c17ac3d320a7ec4/addons/mail/static/src/js/onchange_on_keydown.js#L69, the fix in other PR and be sure to test in the both modules.

xmglord commented 5 months ago

@luisg123v please review but don't merge until @rolandojduartem give his functional review.

rolandojduartem commented 5 months ago

No, the changes on stock_by_warehouse must be other PR, that is a fix, not a migration, you can rebase over that PR for functional review, but I do not think is a good idea mix changes in the same PR

rolandojduartem commented 5 months ago

This MR is not rebased over !1651, so it fails

xmglord commented 5 months ago

This MR is not rebased over !1651, so it fails

I already rebase but for some reason when installing this modules the widget fails.

desdelinux commented 4 months ago

Hello, what are we missing here? @luisg123v @xmglord

rolandojduartem commented 4 months ago

is this ready for functional review?

xmglord commented 4 months ago

@rolandojduartem yes, this is ready for functional review.

rolandojduartem commented 4 months ago

I am going to test it then

rolandojduartem commented 4 months ago

I think it is not working as I expected, see the sale order, I did not activate the button and the widget was loaded at the beggining, could you check it?

Screenshot from 2024-05-16 12-16-05

Screenshot from 2024-05-16 12-14-39

rolandojduartem commented 4 months ago

Alsoo llok the button, the widget and the button are so close

xmglord commented 4 months ago

@rolandojduartem I already fix the space between the widget and the button, please review again.

desdelinux commented 4 months ago

Friendly Reminder @rolandojduartem

rolandojduartem commented 4 months ago

Functionally and technically LGTM @luisg123v