Vauxoo / addons-vauxoo

All our modules related to developments that solves generic issues on Odoo, or that solve internal problems on Odoo Core, if something is here, maybe it is solving an issue in your company, try it and report what you see.
http://www.vauxoo.com
193 stars 288 forks source link

[REM] sale_margin_percentage: remove margin_percentage field in favor of native one I#25764 #1644

Closed xmglord closed 5 months ago

xmglord commented 6 months ago

The field margin_percentage is no longer needed since native module sale_margin have the field margin_percent that serve the same propose. Also the field margin_threshold must be updated since it was used as a percentage but the native field margin_percent is a ration so we must follow the same pattern.

xmglord commented 5 months ago

@isaako34 and @rolandojduartem please review.

rolandojduartem commented 5 months ago

There errors in the CI, is that expected?

xmglord commented 5 months ago

@luisg123v please review.