Vauxoo / docker-odoo-image

Base docker image for instances
GNU General Public License v2.0
18 stars 29 forks source link

Change Vim Theme to heliotrope, so relevant info be visible #106

Closed hbto closed 8 years ago

hbto commented 8 years ago

Before heliotrope theme

vim_before

After heliotrope theme

vim_after
osvalr commented 8 years ago

what filetypes are supported? does XML get syntax-highlighted?

hbto commented 8 years ago

@osvalr

Before

vim-xml-before

After

vim-xml-after
LuisAlejandro commented 8 years ago

When you reach an agreement about this, i can take care of it.

You should bring other people to discuss on whether they like this theme or not.

Greetings!

On Thu, Apr 21, 2016 at 8:08 PM, Hbto [ Vauxoo ] notifications@github.com wrote:

@osvalr https://github.com/osvalr

Before [image: vim-xml-before] https://cloud.githubusercontent.com/assets/7598010/14728218/a1676334-07fc-11e6-9a8c-f714e680d8ed.png

After [image: vim-xml-after] https://cloud.githubusercontent.com/assets/7598010/14728226/a82e99a8-07fc-11e6-910a-b80754b42b10.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/Vauxoo/docker-odoo-image/issues/106#issuecomment-213180619

hbto commented 8 years ago

+1 @LuisAlejandro

LuisAlejandro commented 8 years ago

@moylop260 @ruiztulio @nhomar what do you think of this request? no one has commented.

zaoral commented 8 years ago

I think is required. when trying to select lines inside a xml file the selection lines get black and nothing can be read, same as comments inside files.

I think this should be solved. I think this theme is a good idea

Best Regards

moylop260 commented 8 years ago

Let's try Who make the PR?

LuisAlejandro commented 8 years ago

I included the change here https://github.com/Vauxoo/docker-odoo-image/pull/105/commits/5cadcb403d5046b30395518d49bc5ef558acaa15 When #105 is merged it should be done.

LuisAlejandro commented 8 years ago

To test locally before the merge of #105:

Log into the shippable image:

docker run -it vauxoo/odoo-80-image-shippable-auto bash

Change the line 1252 of /root/.vimrc:

- colorscheme ir_black
+ colorscheme heliotrope

Restart vim.

hbto commented 8 years ago

@LuisAlejandro

Oh!! +1